| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Nikolay Shaplov <dhyan(at)nataraj(dot)su>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist |
| Date: | 2018-01-23 17:03:50 |
| Message-ID: | b9fd08ee-dda2-765f-18b1-08a1b810fe19@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/18/18 18:42, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Jan 17, 2018 at 3:50 PM, Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:
>>> This patch raises error if user tries o set or change toast.* option for a
>>> table that does not have a TOST relation.
> There might be a case for raising a warning in this situation,
> but I would disagree with making it a hard error in any case.
> All that's going to accomplish is to break people's scripts and
> get them mad at you.
It might also be useful to set these reloptions before you add a new
column to a table.
So I think this change is not desirable.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-01-23 17:06:29 | Re: Test-cases for exclusion constraints is missing in alter_table.sql file |
| Previous Message | Peter Eisentraut | 2018-01-23 16:51:27 | Re: PATCH: Configurable file mode mask |