| From: | "Dan Thomas" <godders(at)gmail(dot)com> | 
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org | 
| Subject: | tiny patch to make vacuumdb -a's database order match pg_dumpall | 
| Date: | 2006-09-17 05:14:42 | 
| Message-ID: | b9aff96f0609162214h4460c278m96c751b21402e90b@mail.gmail.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches | 
Hiya,
I've been having trouble running vacuumdb -a and pg_dumpall
concurrently because they run through the databases in a different
order (so dumpall was getting stuck behind vacuum's lock, and my
firewall was rather unhelpfully closing the idle connection). I can't
see a good reason for them to be using a different order, and as it
will only affect those that have created new databases since restoring
from a dump, may not be instantly obvious. It appears slightly more
thought has gone into pg_dumpall's code (in that it actually includes
an ORDER BY), so I elected to fiddle with vacuumdb.
I hope this is in the correct format (this is the first patch I've
submitted for anything), please let me know if I've done something
daft.
Dan
237c237
<       result = executeQuery(conn, "SELECT datname FROM pg_database
WHERE datallowconn;", progname, echo);
---
>       result = executeQuery(conn, "SELECT datname FROM pg_database WHERE datallowconn ORDER BY 1;", progname, echo);
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2006-09-17 06:42:51 | Re: -HEAD planner issue wrt hash_joins on dbt3 ? | 
| Previous Message | David Fuhry | 2006-09-17 04:54:12 | Re: GIN documentation | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joachim Wieland | 2006-09-17 09:49:51 | Re: [HACKERS] Timezone List | 
| Previous Message | Tom Lane | 2006-09-17 02:31:48 | Re: Timezone List |