| From: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Geoghegan <pg(at)bowt(dot)ie>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com> |
| Subject: | Re: check_strxfrm_bug() |
| Date: | 2023-04-22 19:14:49 |
| Message-ID: | b9aa4446-45a0-b695-7e50-9557b385ea25@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/19/23 9:34 PM, Thomas Munro wrote:
> On Wed, Apr 19, 2023 at 2:31 PM Jonathan S. Katz <jkatz(at)postgresql(dot)org> wrote:
>> To be clear, is the proposal to remove both "check_strxfrm_bug" and
>> "TRUST_STRXFRM"?
>>
>> Given a bunch of folks who have expertise in this area of code all agree
>> with removing the above as part of the collation cleanups targeted for
>> v16, I'm inclined to agree. I don't really see the need for an explicit
>> RMT action, but based on the consensus this seems OK to add as an open item.
>
> Thanks all. I went ahead and removed check_strxfrm_bug().
Thanks! For housekeeping, I put this into "Open Items" and marked it as
resolved.
> I could write a patch to remove the libc strxfrm support, but since
> Jeff recently wrote new code in 16 to abstract that stuff, he might
> prefer to look at it?
I believe we'd be qualifying this as an open item too? If so, let's add it.
Thanks,
Jonathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2023-04-22 19:25:11 | Re: pg_stat_io not tracking smgrwriteback() is confusing |
| Previous Message | Tom Lane | 2023-04-22 17:52:55 | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |