Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c)

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: ranier(dot)vf(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c)
Date: 2023-09-13 15:14:11
Message-ID: b99ce0835797a6659de1a54c9f973e7b0e9a0e92.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2023-09-13 at 11:48 +0900, Michael Paquier wrote:
> Hmm.  I see your point, one could be confused that the function name
> is the provider with this wording.  How about that instead:
>  ERROR:  unsupported collprovider for %s: %c
>
> I've hidden that in a macro that uses __func__ as Jeff has suggested.
>
> What do you think?

Looks good to me, thank you.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-09-13 16:59:04 Re: Add 'worker_type' to pg_stat_subscription
Previous Message Aleksander Alekseev 2023-09-13 14:36:21 Re: pg_resetwal tests, logging, and docs update