| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: PATCH: Exclude unlogged tables from base backups |
| Date: | 2017-12-13 15:44:38 |
| Message-ID: | b947f3a1-cc9d-2aec-da43-ce19c06c22a2@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/13/17 10:04 AM, Stephen Frost wrote:
>
> Just to be clear- the new base backup code doesn't actually *do* the
> non-init fork removal, it simply doesn't include the non-init fork in
> the backup when there is an init fork, right?
It does *not* do the unlogged non-init fork removal. The code I
refactored in reinit.c is about identifying the forks, not removing
them. That code is reused to determine what to exclude from the backup.
I added the regression tests to ensure that the behavior of reinit.c is
unchanged after the refactor.
> We certainly wouldn't want a basebackup actually running around removing
> the main fork for unlogged tables on a running and otherwise healthy
> system. ;)
That would not be good.
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-12-13 15:45:08 | Re: WIP: a way forward on bootstrap data |
| Previous Message | Peter Eisentraut | 2017-12-13 15:40:46 | Re: server crash with CallStmt |