On 2023-12-29 Fr 17:56, Peter Eisentraut wrote:
> Follow-up fixes for "Make all Perl warnings fatal"
>
> Mostly, we need to check whether $ENV{PG_TEST_EXTRA} is set before
> doing regular expression matches against it.
This reads a bit oddly to me.
-elsif ($ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
+elsif (!$ENV{PG_TEST_EXTRA} || $ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
I think I would have changed it like this
elsif (($ENV{PG_TEST_EXTRA" || "") !~ /\bkerberos\b/)
which is an idiom we've used elsewhere.
Still, TIMTOWTDI.
cheers
andrew (japh)
--
Andrew Dunstan
EDB: https://www.enterprisedb.com