Re: patch: fixing dublicates foreign-tables

hello, Akshay!

screenshot:

"Screenshot from 2015-12-08 13-43-54 with-labels.png" (as attachment
file).

script to reproduce:

CREATE FOREIGN DATA WRAPPER postgresql
VALIDATOR postgresql_fdw_validator;

CREATE SERVER film_server FOREIGN DATA WRAPPER postgresql
OPTIONS (host 'foo', dbname 'foodb', port '5432');

CREATE FOREIGN TABLE films1 (
code char(5) NOT NULL,
title varchar(40) NOT NULL,
did integer NOT NULL,
date_prod date,
kind varchar(10),
len interval hour to minute
)
SERVER film_server;

CREATE FOREIGN TABLE films2 (
code char(5) NOT NULL,
title varchar(40) NOT NULL,
did integer NOT NULL,
date_prod date,
kind varchar(10),
len interval hour to minute
)
SERVER film_server;

COMMENT ON FOREIGN TABLE films1 IS 'description A';
COMMENT ON FOREIGN TABLE films2 IS 'description B';

COMMENT ON COLUMN films1.code IS 'descr code A';
COMMENT ON COLUMN films1.title IS 'descr title A';
COMMENT ON COLUMN films1.did IS 'descr did A';
COMMENT ON COLUMN films2.code IS 'descr code B';
COMMENT ON COLUMN films2.title IS 'descr title B';
COMMENT ON COLUMN films2.did IS 'descr did B';

Akshay Joshi писал 2015-12-08 13:21:
> Hi Andrej
>
> Can you please share the reproduction step of the issue that you have
> fixed.
>
> On Tue, Dec 8, 2015 at 11:15 AM, Akshay Joshi
> <akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> On Tue, Dec 8, 2015 at 11:09 AM, Dave Page <dpage(at)pgadmin(dot)org>
>> wrote:
>>
>>> Akshay, can you review this please?
>>
>> Sure, Dave.
>>
>>> 2015-12-07 19:47 GMT+05:30 Andrej Antonov <antonov(at)imp-m(dot)ru>:
>>>> fixing dublicates foreign-tables (see attachment file).
>>>>
>>>> this email -- it is just copy of pull-request
>>>> https://github.com/postgres/pgadmin3/pull/11 [1] .
>>>>
>>>> thanks in advance.
>>>>
>>>> --
>>>> Андрей Антонов,
>>>> инженер-программист отдела
>>> информационных технологий и
>>> программирования,
>>>> компания «Импульс М»
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list
>>> (pgadmin-hackers(at)postgresql(dot)org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers [2]
>>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com [3]
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com [4]
>>> The Enterprise PostgreSQL Company
>>
>> --
>>
>> AKSHAY JOSHI
>> PRINCIPAL SOFTWARE ENGINEER
>>
>> Phone: +91 20-3058-9517
>> Mobile: +91 976-788-8246
>
> --
>
> AKSHAY JOSHI
> PRINCIPAL SOFTWARE ENGINEER
>
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246
>
> Links:
> ------
> [1] https://github.com/postgres/pgadmin3/pull/11
> [2] http://www.postgresql.org/mailpref/pgadmin-hackers
> [3] http://pgsnake.blogspot.com
> [4] http://www.enterprisedb.com

--
Андрей Антонов,
инженер-программист отдела информационных технологий и программирования,
компания «Импульс М»