| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proper object locking for GRANT/REVOKE |
| Date: | 2024-11-15 10:19:50 |
| Message-ID: | b8b49eb7-7fcb-4006-bed1-e56aa7304290@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11.11.24 08:53, Bertrand Drouvot wrote:
>> Maybe it would be better to push the assertion into get_object_address(),
>> something like
>>
>> Assert(!relation || relp)
>>
>> near the end.
>
> That looks like a good idea to me, that would make the code cleaner and easier
> to understand.
>
>> Meaning, if you pass NULL for the relp argument, then you
>> don't expect a relation. This is kind of what will happen now anyway,
>> except with a segfault instead of an assertion.
>
> Yeah, I like it.
>
> So, something like the attached (provided as .txt file to no mess up the CF bot
> entry related to this thread) could be applied before?
Thanks. I have applied your patch and then also mine with the
appropriate adjustments.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2024-11-15 10:20:10 | Re: NOT ENFORCED constraint feature |
| Previous Message | Tender Wang | 2024-11-15 10:10:17 | Re: Tweak some codes format in gist.c |