| From: | "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Sergei Kornilov <sk(at)zsrv(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: Online enabling of checksums |
| Date: | 2018-07-31 19:52:40 |
| Message-ID: | b87e9f3f-a647-571d-2168-bc5d48e1ff5b@commandprompt.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/31/2018 12:45 PM, Bruce Momjian wrote:
>
>> Hi!,
>>
>> Thanks for reviewing, I’ve updated the patch with the above mentioned incorrect
>> linkends as well as fixed the comments you made in a previous review.
>>
>> The CF-builder-bot is red, but it’s because it’s trying to apply the already
>> committed patch which is in the attached datallowconn thread.
> I think checksumhelper_cost_delay should be checksum_helper_cost_delay.
> ^
>
> Is "helper" the right word?
Based on other terminology within the postgresql.conf should it be
"checksum_worker_cost_delay"?
JD
>
--
Command Prompt, Inc. || http://the.postgres.company/ || @cmdpromptinc
*** A fault and talent of mine is to tell it exactly how it is. ***
PostgreSQL centered full stack support, consulting and development.
Advocate: @amplifypostgres || Learn: https://postgresconf.org
***** Unless otherwise stated, opinions are my own. *****
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2018-07-31 20:06:45 | Re: GiST VACUUM |
| Previous Message | Bruce Momjian | 2018-07-31 19:45:35 | Re: Online enabling of checksums |