Re: Document DateStyle effect on jsonpath string()

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Document DateStyle effect on jsonpath string()
Date: 2024-09-10 20:10:47
Message-ID: b847bc16-57b4-4701-870b-c4ed33d71e51@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Isn't this behavior actually a bug that should be fixed rather than
documented?

These JSON path functions are specified by the SQL standard, so they
shouldn't depend on PostgreSQL-specific settings. At least in new
functionality we should avoid that, no?

On 10.09.24 21:43, David E. Wheeler wrote:
> On Sep 10, 2024, at 14:51, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>> Pushed with a little additional polishing.
>
> Thank you! Do you think it’d be worthwhile to back port to 17?
>
>> I thought the best way to address jian's complaint about DateStyle not
>> being clearly locked down was to change horology.sql to verify the
>> prevailing setting, as it has long done for TimeZone. That's the
>> lead test script for related stuff, so it makes the most sense to
>> do it there. Having done that, I don't feel a need to duplicate
>> that elsewhere.
>
> Yeah, that will help, but I still bet next time I go to figure out what it is I’ll stick that line in some test to make it fail with clear output for what it’s set to 😂.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-09-10 20:15:55 Re: json_query conditional wrapper bug
Previous Message Tomas Vondra 2024-09-10 19:47:16 Re: BUG #18598: AddressSanitizer detects use after free inside json_unique_hash_match()