| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, noriyoshi(dot)shinoda(at)hpe(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org, craig(at)2ndquadrant(dot)com |
| Subject: | Re: Logical Replication and Character encoding |
| Date: | 2017-03-03 19:51:22 |
| Message-ID: | b8292d73-4d98-7663-26ef-c8f5569a3da9@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/03/17 20:37, Peter Eisentraut wrote:
> On 2/27/17 00:23, Kyotaro HORIGUCHI wrote:
>> Yeah, the patch sends converted string with the length of the
>> orignal length. Usually encoding conversion changes the length of
>> a string. I doubt that the reverse case was working correctly.
>
> I think we shouldn't send the length value at all. This might have been
> a leftover from an earlier version of the patch.
>
> See attached patch that removes the length value.
>
Well the length is necessary to be able to add binary format support in
future so it's definitely not an omission.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2017-03-03 19:53:46 | Re: RADIUS fallback servers |
| Previous Message | Peter Geoghegan | 2017-03-03 19:49:36 | Re: GUC for cleanup indexes threshold. |