| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Rename PageData to XLogPageData |
| Date: | 2024-10-03 11:31:19 |
| Message-ID: | b813255e-b4fc-4b9a-9b52-f8be5d3ea991@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02.10.24 19:02, Heikki Linnakangas wrote:
>> This patch renames that type to a more specific name XLogPageData.
>> This makes room for possibly adding another PageData type with the
>> earlier meaning, but that's not done here. But I think even without
>> that, this patch is a useful little cleanup that makes the code more
>> consistent and clear.
>
> +1 for renaming, but -1 on XLogPageData. That sounds like a WAL page,
> see XLogPageHeaderData for example. I'd suggest GenericXLogPageData or
> just GenericPerPageData or something.
Sounds good. Here is an updated version.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Rename-PageData-to-GenericXLogPageData.patch | text/plain | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maxim Orlov | 2024-10-03 12:09:08 | Re: Do not lock temp relations |
| Previous Message | Vinícius Abrahão | 2024-10-03 11:21:37 | Re: Possibilities on code change to implement pseudodatatypes |