Re: confusing positioning of notes in connection settings

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org>
Subject: Re: confusing positioning of notes in connection settings
Date: 2023-06-07 15:17:47
Message-ID: b7d65e59-92a1-488f-7859-632c1f44d69a@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On 05.06.23 19:10, Jonathan S. Katz wrote:
> On 5/31/23 7:53 AM, Daniel Gustafsson wrote:
>>> On 31 May 2023, at 13:16, Peter Eisentraut
>>> <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>>
>>> The first two hunks are pretty straightforward, they just move the
>>> existing text around.
>>>
>>> For the other two, which are not supported on Windows, I added an
>>> explicit parenthetical note.  We don't list which of the Unix-like
>>> platforms support the respective options, but I suspect that it's all
>>> of them in practice?  (Otherwise we should be more explicit.)  So I
>>> think calling out Windows explicitly is sensible, also considering
>>> that the first two settings are supported on Windows but the latter
>>> two are not.
>>
>> I think this is a clear improvement over the current docs.
>
> +1.
>
> Small nit:
>
> "which does not include Windows" =>
> "which is not supported on Windows"
>
> (in two places)

The proposed text in the patch is

"This parameter is supported only on systems that {have this property}
(which does not include Windows)."

I don't see how the change you are proposing is correct.

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Jonathan S. Katz 2023-06-07 15:34:08 Re: confusing positioning of notes in connection settings
Previous Message vignesh C 2023-06-07 10:39:47 Re: clarifying trigger/rule behavior on logical replication subscribers