| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Inconsistency in reporting checkpointer stats |
| Date: | 2024-10-02 02:21:50 |
| Message-ID: | b7a739fb-8bc1-4ea8-a1fd-cfede2346f36@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/10/02 1:50, Nitin Jadhav wrote:
>> Before committing the patch, I revised it with the following changes:
>>
>> - I added "shared" to the description of pg_stat_checkpointer.buffers_written
>> to clarify that it tracks shared buffers.
>> - In the checkpoint log message, I replaced "slru" with "SLRU" for consistency,
>> as uppercase is typically used for SLRU.
>> - I updated the commit message.
>
> Thanks for updating. Looks good to me.
Thanks for the review! Pushed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-10-02 02:28:26 | Re: Call rm_redo in a temporary memory context |
| Previous Message | jian he | 2024-10-02 01:50:47 | Re: general purpose array_sort |