From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | move collation import to backend |
Date: | 2016-10-28 01:56:53 |
Message-ID: | b78a8524-0412-5605-54d1-972b481eb16d@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Currently, initdb parses locale -a output to populate pg_collation. If
additional collations are installed in the operating system, it is not
possible to repeat this process, only by doing each step manually. So I
propose to move this to a backend function that can be called
separately, and have initdb call that. Running this logic in the
backend instead of initdb also makes the code simpler. If we add other
collation providers such as ICU, initdb doesn't need to know about that
at all, because all the logic would be contained in the backend.
Here is an example:
select pg_import_system_collations(if_not_exists => false, schema =>
'test');
(Specifying the schema also allows testing this without overwriting
pg_catalog.)
I thought about making this a top-level command (IMPORT COLLATIONS ...
?) but decided against it for now, to keep it simple. Right now, this
is more of a refactoring. Documentation could be added if we decide so.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Add-function-to-import-operation-system-collations.patch | text/x-patch | 13.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2016-10-28 02:38:49 | Re: make coverage-html on OS X |
Previous Message | Tsunakawa, Takayuki | 2016-10-28 01:45:07 | Re: [RFC] Should we fix postmaster to avoid slow shutdown? |