| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Remove distprep |
| Date: | 2024-06-20 07:29:45 |
| Message-ID: | b7060f09-1da5-4405-adde-907719c96092@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16.06.24 21:34, Noah Misch wrote:
> On Thu, Oct 05, 2023 at 05:46:46PM +0200, Peter Eisentraut wrote:
>> --- a/src/backend/Makefile
>> +++ b/src/backend/Makefile
>
>> $(top_builddir)/src/include/storage/lwlocknames.h: storage/lmgr/lwlocknames.h
>> - prereqdir=`cd '$(dir $<)' >/dev/null && pwd` && \
>> - cd '$(dir $@)' && rm -f $(notdir $@) && \
>> - $(LN_S) "$$prereqdir/$(notdir $<)" .
>> + rm -f '$@'
>> + $(LN_S) ../../backend/$< '$@'
>>
>> $(top_builddir)/src/include/utils/wait_event_types.h: utils/activity/wait_event_types.h
>> - prereqdir=`cd '$(dir $<)' >/dev/null && pwd` && \
>> - cd '$(dir $@)' && rm -f $(notdir $@) && \
>> - $(LN_S) "$$prereqdir/$(notdir $<)" .
>> + rm -f '$@'
>> + $(LN_S) ../../backend/$< '$@'
>
> These broke the
> https://www.postgresql.org/docs/17/installation-platform-notes.html#INSTALLATION-NOTES-MINGW
> build, where LN_S='cp -pR'. On other platforms, "make LN_S='cp -pR'"
> reproduces this. Reverting the above lines fixes things. The buildfarm has
> no coverage for that build scenario (fairywren uses Meson).
Is it just these two instances?
Commit 721856ff24b contains a few more hunks that change something about
LN_S. Are those ok?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2024-06-20 07:55:19 | Re: ON ERROR in json_query and the like |
| Previous Message | vignesh C | 2024-06-20 07:21:57 | Re: Pgoutput not capturing the generated columns |