Re: Should `pg_upgrade --check` check relation filenodes are present?

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Craig de Stigter <craig(dot)destigter(at)koordinates(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Should `pg_upgrade --check` check relation filenodes are present?
Date: 2017-02-02 05:10:17
Message-ID: b65284a8-e218-9625-b1d7-75c86137b8f2@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/31/17 4:57 PM, Craig de Stigter wrote:
> However, this problem was not caught by the `--check` command. I'm
> looking at the source code and it appears that pg_upgrade does not
> attempt to verify relation filenodes actually exist before proceeding,
> whether using --check or not.

The purpose of --check is to see if there is anything in your database
that pg_upgrade cannot upgrade. Its purpose is not to detect general
damage in a database.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-02-02 05:13:12 Re: Cannot shutdown subscriber after DROP SUBSCRIPTION
Previous Message Michael Paquier 2017-02-02 05:09:09 Re: [Bug fix] PQsendQuery occurs error when target_session_attrs is set to read-write