Re: Add privileges test for pg_stat_statements to improve coverage

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: kuroda(dot)keisuke(at)nttcom(dot)co(dot)jp, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add privileges test for pg_stat_statements to improve coverage
Date: 2024-07-23 05:28:14
Message-ID: b600bb44-1828-4ddb-8432-f789b91a44bc@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024/07/23 10:40, kuroda(dot)keisuke(at)nttcom(dot)co(dot)jp wrote:
> I agree.
> The information of different userids is mixed up.
> It is easier to understand if the role name is displayed.
> Join with pg_roles (view of pg_authid) to output the role name.

+ rolname | queryid_bool | query | calls | rows
+---------------------+--------------+----------------------------------------------------+-------+------
+ postgres | t | SELECT $1 AS "ONE" | 1 | 1
+ postgres | t | SELECT pg_stat_statements_reset() IS NOT NULL AS t | 1 | 1
+ regress_stats_user1 | t | SELECT $1+$2 AS "TWO" | 1 | 1

Using "postgres" as the default superuser name can cause instability.
This is why the Patch Tester reports now test failures again.
You should create and use a different superuser, such as "regress_stats_superuser."

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2024-07-23 05:32:50 Re: Logical Replication of sequences
Previous Message Ron Johnson 2024-07-23 05:21:32 Re: Enhance pg_dump multi-threaded streaming (WAS: Re: filesystem full during vacuum - space recovery issues)