| From: | Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] add concurrent_abort callback for output plugin |
| Date: | 2021-03-31 13:50:53 |
| Message-ID: | b55eed47-e230-674f-4407-686b5526d2fa@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31.03.21 15:18, Amit Kapila wrote:
> On Wed, Mar 31, 2021 at 11:55 AM Markus Wanner
>> The last sentences there now seems to relate to just the setting of
>> "concurrent_abort", rather than the whole reason to invoke the
>> prepare_cb. And the reference to the "gid" is a bit lost. Maybe:
>>
>> "Thus even in case of a concurrent abort, enough information is
>> provided to the output plugin for it to properly deal with the
>> <command>ROLLBACK PREPARED</command> once that is decoded."
>
> Okay, Changed the patch accordingly.
That's fine with me. I didn't necessarily mean to eliminate the hint to
the concurrent_abort field, but it's more concise that way. Thank you.
Regards
Markus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sebastian Cabot | 2021-03-31 13:54:24 | Prevent query cancel packets from being replayed by an attacker (From TODO) |
| Previous Message | Arseny Sher | 2021-03-31 13:39:39 | Re: Flaky vacuum truncate test in reloptions.sql |