Re: pgsql: Add TAP tests for pg_dump

On 5/6/16 4:07 PM, Stephen Frost wrote:
> Are you suggesting commiting to still-9.6-HEAD post-beta1? I took
> Peter's comment as suggesting that adding the tests would have to wait
> til after we branched 9.6, as we do for features.
>
> I'd really like to have these tests included as that will make them
> available to others more easily to add on to, and I'm certainly planning
> to continue adding tests until I get pg_dump.c's coverage a lot better.
> That seems like the perfect kind of effort that should be happening
> right now- adding more tests and working to make sure that what's been
> committed is correct (and fixing it when it isn't, as discovered by the
> test suite with transforms and casts...).

Well, we all want to get our code in and let others make it better. But
here we are trying to get a release out in a few days with only a
weekend in between, and we are still trying to figure out basic
portability issues using build-farm-whacking technology. This is not
the time.

Again, I applaud this, but this is clearly a new major chunk of mostly
not-peer-reviewed code with potential for portability problems and the
possibility to break downstream packaging routines. There is no harm in
leaving this for 9.7.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services