Re: PQinitSSL broken in some use casesf

From: Merlin Moncure <mmoncure(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Chernow <ac(at)esilo(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PQinitSSL broken in some use casesf
Date: 2009-02-13 22:04:56
Message-ID: b42b73150902131404l69e078d1j445eca548becc9d4@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 13, 2009 at 4:53 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> BTW, the bitmask isn't perfect either --- doesn't it just reintroduce
>> the problem already complained of with your idea for PQinitSSL? That
>> is, how does the client know whether the function recognized all the
>> bits it passed?
>
> Well, if we add the PQgetLibraryVersion() function I suggested
> upthread, then it can check that first. I find it difficult to
> believe that isn't a good idea independently of how we solve this
> particular problem.

I'd prefer PQversion() as a name. Also, it doesn't necessarily handle
the issue directly. For example, it doesn't tell you which bits are
valid...you have to guess. Also, do we really need a function for
this?

Is the generic init worth discussion or a non starter? I guess we
have a scheduling problem here...I think the ssl problem is serious
enough to warrant a fast-track into 8.4, but maybe it's 'too much' to
hash out a generic library initialization routine this late in the
cycle.

merlin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-02-13 22:05:58 Re: PQinitSSL broken in some use casesf
Previous Message Tom Lane 2009-02-13 21:54:50 Re: [patch] fix for regression tests (locale cs_CZ)