Re: libpq object hooks (libpq events)

From: "Merlin Moncure" <mmoncure(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Andrew Chernow" <ac(at)esilo(dot)com>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: libpq object hooks (libpq events)
Date: 2008-05-20 17:29:55
Message-ID: b42b73150805201029i5d1dbdcbj7941518c5bc0bf28@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Mon, May 19, 2008 at 8:22 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andrew Chernow <ac(at)esilo(dot)com> writes:
>> Here is an updated patch for what was called object hooks. This is now
>> called libpq events. If someone has a better name or hates ours, let us
>> know.
>
> This is starting to get there,

Interesting you haven't commented on two areas, the actual placement
of the event callers in the libpq code (i'm assuming these are ok),
and the PQcopyResult/PQsetvalue functions. The latter area introduces
some new behavior into standard libpq (imo) so it deserves some
scrutiny.

merlin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2008-05-20 18:03:17 idea: storing view source in system catalogs
Previous Message Greg Smith 2008-05-20 17:20:48 Re: triggers on prepare, commit, rollback... ?

Browse pgsql-patches by date

  From Date Subject
Next Message Guillaume Lelarge 2008-05-20 20:23:19 Re: Patch to change psql default banner v6
Previous Message Bryce Nesbitt 2008-05-20 15:23:03 Re: Patch to change psql default banner v6