From: | "Merlin Moncure" <mmoncure(at)gmail(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Andrew Chernow" <ac(at)esilo(dot)com>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: libpq object hooks (libpq events) |
Date: | 2008-05-20 02:53:23 |
Message-ID: | b42b73150805191953t1ca371c9g2387a104cf03b828@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Mon, May 19, 2008 at 10:37 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andrew Chernow <ac(at)esilo(dot)com> writes:
>> 4. add a setter for result instance data
>> - There should also be a PQsetInstanceData(PGconn*, ...)
>> - I see no need for a passThrough setter
>
> Check, though I assume we're not expecting PQsetInstanceData to
> propagate to previously created PGresults?
>
>> 5. move callback stuff to its own header, maybe pgcallback.h?
>
> Should be libpq-something. I was considering libpq-hooks.h or
> libpq-events.h, but libpq-callback.h would be OK too.
I think 'events' best describes what is going on. Your other
suggestions are improvements (we maybe tried a little too hard to
minimize exports). Losing the global hooks is no problem (it was
basically syntax sugar).
merlin
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Chernow | 2008-05-20 03:03:48 | Re: libpq object hooks (libpq events) |
Previous Message | Tom Lane | 2008-05-20 02:37:58 | Re: libpq object hooks (libpq events) |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Chernow | 2008-05-20 03:03:48 | Re: libpq object hooks (libpq events) |
Previous Message | Tom Lane | 2008-05-20 02:37:58 | Re: libpq object hooks (libpq events) |