Re: libpq patch for pqtypes hook api and PGresult creation

From: "Merlin Moncure" <mmoncure(at)gmail(dot)com>
To: "Andrew Chernow" <ac(at)esilo(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: libpq patch for pqtypes hook api and PGresult creation
Date: 2008-04-11 17:57:46
Message-ID: b42b73150804111057o255ab305ved7d3840ad65acf@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Fri, Apr 11, 2008 at 1:47 PM, Andrew Chernow <ac(at)esilo(dot)com> wrote:
> Here are the changes to libpq. It adds the ability to register an Object
> Hook and create a home-grown result. Patch adds 4 functions.
>
> We changed the name of PQresultSetFieldValue to PQsetvalue, which better
> compliments PQgetvalue. If this patch is acceptable, we will move on to
> making the required changes to pqtypes; some work has already been done.

Whoops! One missing thing here...we forgot to make pqResultAlloc
pubilc...pqResultAlloc -> PQresultAlloc (see discussion in -hackers).
Also, we could use pqResultStrdup (or keep it private, in which case
we can re-implement in libpqtypes).

merlin

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Chernow 2008-04-11 18:41:40 libpq Win32 Mutex performance patch
Previous Message Andrew Chernow 2008-04-11 17:47:58 libpq patch for pqtypes hook api and PGresult creation