Re: minor bug

From: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
To: Torsten Förtsch <tfoertsch123(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: minor bug
Date: 2023-01-17 09:42:03
Message-ID: b41b61c8ba52efa23d1079cc53c689713f5b1e0c.camel@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Mon, 2023-01-16 at 19:59 +0100, Torsten Förtsch wrote:
> not sure if this is known behavior.
>
> Server version is 14.6 (Debian 14.6-1.pgdg110+1).
>
> In a PITR setup I have these settings:
>
> recovery_target_xid = '852381'
> recovery_target_inclusive = 'false'
>
> In the log file I see this message:
>
> LOG:  recovery stopping before commit of transaction 852381, time 2000-01-01 00:00:00+00
>
> But:
>
> postgres=# select * from pg_last_committed_xact();
>   xid   |           timestamp           | roident
> --------+-------------------------------+---------
>  852380 | 2023-01-16 18:00:35.054495+00 |       0
>
> So, the timestamp displayed in the log message is certainly wrong.

Redirected to -hackers.

If recovery stops at a WAL record that has no timestamp, you get this
bogus recovery stop time. I think we should show the recovery stop time
only if time was the target, as in the attached patch.

Yours,
Laurenz Albe

Attachment Content-Type Size
0001-Don-t-show-bogus-recovery-stop-time.patch text/x-patch 1.9 KB

In response to

  • minor bug at 2023-01-16 18:59:33 from Torsten Förtsch

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Michael Paquier 2023-01-17 10:12:33 Re: minor bug
Previous Message Laurenz Albe 2023-01-17 08:26:13 Re: Are ZFS snapshots unsafe when PGSQL is spreading through multiple zpools?

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2023-01-17 09:48:36 Re: Cross-partition UPDATE and foreign table partitions
Previous Message shiy.fnst@fujitsu.com 2023-01-17 09:33:18 Update comments in multixact.c