Re: pgsql: Fix gratuitous error message variation

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix gratuitous error message variation
Date: 2019-11-09 08:01:56
Message-ID: b2fdd2de-ddc9-0d30-6f44-0e424825b328@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-11-09 02:20, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> Fix gratuitous error message variation
>
> Hm, as long as you're touching that ... OIDs should be formatted
> with %u not %d.

This is just a fixup of the recent patch
8f75e8e44609335e6bdd73123284682235f242a2.

Replication origin IDs are actually

typedef uint16 RepOriginId;

so using the term OID is probably wrong altogether. I'm not sure what
the overall intent was here.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2019-11-09 08:17:03 pgsql: Fix negative bitmapset member not allowed error in logical repli
Previous Message Michael Paquier 2019-11-09 06:44:36 pgsql: Fix new COPY test of PL/pgSQL with VPATH builds