From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Devrim Gündüz <devrim(at)gunduz(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: drop support for Python 2.3 |
Date: | 2017-02-21 17:02:52 |
Message-ID: | b2e8f44c-7e90-4372-731a-745a72bd4449@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2/21/17 10:18, Tom Lane wrote:
> Based on some not-fun I had along the way to that, I think it would be
> a good idea to do the Python version check a bit earlier than you have
> here. The shlib search in PGAC_CHECK_PYTHON_EMBED_SETUP is pretty fragile
> and version-dependent, which means that a person could waste a lot of time
> trying to get past the "could not find shared library for Python" error
> before being told that their Python is too old. I propose to move the
> minimum-version check into _PGAC_CHECK_PYTHON_DIRS, say right after the
> [Python configuration directory] stanza. Unless there was some specific
> reason for not wanting it to happen in python.m4?
It's fine to move it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2017-02-21 17:17:16 | Re: DROP SUBSCRIPTION and ROLLBACK |
Previous Message | Peter Eisentraut | 2017-02-21 17:00:55 | Re: safer node casting |