| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Add COMMENT and SECURITY LABEL support for publications and subs |
| Date: | 2017-04-04 13:28:34 |
| Message-ID: | b25dea03-6664-0e44-86d2-5ef23b46e740@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 3/25/17 12:24, Stephen Frost wrote:
>> Add COMMENT and SECURITY LABEL support for publications and subscriptions
>
> Isn't this missing psql tab completion, and pg_dump support? And
> regression tests for the latter?
I have added the tab completion support.
Attached is a patch that adds the pg_dump support, but I'm struggling to
make the tests work. Could you take a look? Problem one I'm seeing is
that the tests assert that there are no comments in the post-data
section, which is no longer the case here. Problem two is that
subscriptions are not dumped by default, so those new tests fail, but I
don't understand why the existing tests about subscriptions work so far.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_dump-Dump-comments-and-security-labels-for-public.patch | invalid/octet-stream | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-04-04 13:59:01 | Re: [COMMITTERS] pgsql: Add COMMENT and SECURITY LABEL support for publications and subs |
| Previous Message | Robert Haas | 2017-04-04 13:08:39 | pgsql: Fix thinko in BitmapAdjustPrefetchIterator. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rahila Syed | 2017-04-04 13:30:21 | Re: Adding support for Default partition in partitioning |
| Previous Message | David Steele | 2017-04-04 13:12:11 | Re: New CORRESPONDING clause design |