| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical decoding vs. VACUUM FULL / CLUSTER on table with TOAST-ed data |
| Date: | 2018-11-28 02:06:58 |
| Message-ID: | b1c612e3-4ca2-20eb-ca14-6d604f3128db@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 28/11/2018 02:14, Andres Freund wrote:
> Hi,
>
> On 2018-11-28 02:04:18 +0100, Tomas Vondra wrote:
>>
>> On 11/24/18 12:20 AM, Tomas Vondra wrote:
>>> ...
>>>
>>> OK, here's an updated patch, tweaking the reorderbuffer part. I plan
>>> to push this sometime mid next week.
>>>
>>
>> Pushed and backpatched to 9.4- (same as e9edc1ba).
>
> Backpatching seems on the more aggressive end of things for an
> optimization. Could you at least announce that beforehand next time?
>
Well, it may be optimization, but from what I've seen the problems
arising from this can easily prevent logical replication from working
altogether as reorder buffer hits OOM on bigger tables. So ISTM that it
does warrant backpatch.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuro Yamada | 2018-11-28 02:27:23 | Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS |
| Previous Message | Thomas Munro | 2018-11-28 01:57:18 | "pg_ctl: the PID file ... is empty" at end of make check |