| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Convert some extern variables to static |
| Date: | 2024-09-24 18:44:49 |
| Message-ID: | b0b7e033-2d37-4885-8919-98e93365c3e4@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 20.09.24 01:48, Thomas Munro wrote:
> On Fri, Sep 20, 2024 at 11:15 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>>> Convert some extern variables to static
>>
>> I'm surprised it took me so long to notice, but this commit
>> makes headerscheck unhappy:
>
> Also discussed at:
>
> https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BYVt5MBD-w0HyHpsGb4U8RNge3DvAbDmOFy_epGhZ2Mg%40mail.gmail.com#aba3226c6dd493923bd6ce95d25a2d77
I have committed the fix discussed there.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-09-24 19:11:23 | pgsql: Tighten up make_libc_collator() and make_icu_collator(). |
| Previous Message | Peter Eisentraut | 2024-09-24 18:44:14 | pgsql: Add further excludes to headerscheck |