Re: pgsql: Allow using syncfs() in frontend utilities.

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathan(at)postgresql(dot)org>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow using syncfs() in frontend utilities.
Date: 2024-03-26 10:18:57
Message-ID: b0a7d540-eb02-4da5-a792-6c9cd6474327@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 22.03.24 17:52, Robert Haas wrote:
> On Wed, Sep 6, 2023 at 7:28 PM Nathan Bossart <nathan(at)postgresql(dot)org> wrote:
>> Allow using syncfs() in frontend utilities.
>>
>> This commit allows specifying a --sync-method in several frontend
>> utilities that must synchronize many files to disk (initdb,
>> pg_basebackup, pg_checksums, pg_dump, pg_rewind, and pg_upgrade).
>> On Linux, users can specify "syncfs" to synchronize the relevant
>> file systems instead of calling fsync() for every single file. In
>> many cases, using syncfs() is much faster.
>>
>> As with recovery_init_sync_method, this new option comes with some
>> caveats. The descriptions of these caveats have been moved to a
>> new appendix section in the documentation.
>
> Hi,
>
> I'd like to complain about this commit's addition of a new appendix.

I already complained about that at
<https://www.postgresql.org/message-id/42804669-7063-1320-ed37-3226d5f1067d@eisentraut.org>
and some follow-up was announced but didn't happen. It was on my list
to look into cleaning up during beta.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2024-03-26 11:09:25 Re: pgsql: make dist uses git archive
Previous Message Amit Kapila 2024-03-26 10:14:29 Re: pgsql: Track last_inactive_time in pg_replication_slots.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-03-26 10:20:50 Re: Introduce XID age and inactive timeout based replication slot invalidation
Previous Message jian he 2024-03-26 10:16:00 Re: remaining sql/json patches