| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - add SHOW_ALL_RESULTS option |
| Date: | 2022-01-15 09:00:11 |
| Message-ID: | alpine.DEB.2.22.394.2201150938470.3378943@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Andres,
> The reason this test constantly fails on cfbot windows is a use-after-free
> bug.
Indeed! Thanks a lot for the catch and the debug!
The ClearOrSaveResult function is quite annoying because it may or may not
clear the result as a side effect.
Attached v14 moves the status extraction before the possible clear. I've
added a couple of results = NULL after such calls in the code.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| psql-show-all-results-14.patch | text/x-diff | 50.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-01-15 09:29:07 | Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work |
| Previous Message | Julien Rouhaud | 2022-01-15 08:50:12 | Re: pg_replslotdata - a tool for displaying replication slot information |