Re: pgsql: psql: Add test for query canceling

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: psql: Add test for query canceling
Date: 2021-08-20 15:40:05
Message-ID: alpine.DEB.2.22.394.2108201736060.498998@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


>> psql: Add test for query canceling
>
> Seems sidewinder didn’t quite like this:

> Nothing obvious sticks out, could it be timing related?

Hmmm. Possibly, as the test is time dependent, hence the "SKIP:" section,
which should mean that the test should be ignore when it fails. It seems
that this part did not work. Maybe it should not state that it is
expecting 2 results?

use Test::More tests => 2;

Replace by:

use Test::More;

Or something is amiss with the "SKIP" section trick?

--
Fabien.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-08-20 18:19:24 pgsql: Fix performance bug in regexp's citerdissect/creviterdissect.
Previous Message Daniel Gustafsson 2021-08-20 11:00:38 Re: pgsql: psql: Add test for query canceling