| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - add SHOW_ALL_RESULTS option |
| Date: | 2021-07-22 14:58:40 |
| Message-ID: | alpine.DEB.2.22.394.2107221655020.25741@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> Ok. I noticed. The patch got significantly broken by the watch pager
>> commit. I also have to enhance the added tests (per Peter request).
>
> I wrote a test to check psql query cancel support. I checked that it fails
> against the patch that was reverted. Maybe this is useful.
Here is the updated version (v8? I'm not sure what the right count is),
which works for me and for "make check", including some tests added for
uncovered paths.
I included your tap test (thanks again!) with some more comments and
cleanup.
I tested manually for the pager feature, which mostly work, althoug
"pspg --stream" does not seem to expect two tables, or maybe there is a
way to switch between these that I have not found.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| psql-show-all-results-8.patch | text/x-diff | 51.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arne Roland | 2021-07-22 15:06:32 | Re: Rename of triggers for partitioned tables |
| Previous Message | Peter Eisentraut | 2021-07-22 14:56:56 | pg_amcheck: Fix block number parsing on command line |