| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: Preventing abort() and exit() calls in libpq |
| Date: | 2021-06-28 08:20:52 |
| Message-ID: | alpine.DEB.2.22.394.2106281013430.1401908@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> +# Check for functions that libpq must not call.
>> +# (If nm doesn't exist or doesn't work on shlibs, this test will silently
>> +# do nothing, which is fine.)
>> +.PHONY: check-libpq-refs
>> +check-libpq-refs: $(shlib)
>> + @! nm -A -g -u $< 2>/dev/null | grep -e abort -e exit
>
> "abort" and "exit" could be generic terms present in some other
> libraries. Could be be better to match with "U abort" and "U exit"
> instead? MinGW has a nm command, and it has a compatible option set,
> so I think that it should work.
A possible trick is to add ccp flags such as: -Dexit=exit_BAD
-Dabort=abort_BAD.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anna Akenteva | 2021-06-28 08:22:01 | Re: Write visibility map during CLUSTER/VACUUM FULL |
| Previous Message | Fabien COELHO | 2021-06-28 08:13:11 | Re: Overflow hazard in pgbench |