| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| Date: | 2021-06-27 05:48:25 |
| Message-ID: | alpine.DEB.2.22.394.2106270745290.482873@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
>> Seem quite unnecessary. We haven't found that to be an issue elsewhere
>> in the code where slurp_file is used. And in the present case we know
>> the file exists because we got its name from list_files().
>
> Agreed. That's an exchange between a hard failure mid-test and a
> failure while letting the whole test run. Here, we expect the test to
> find the log file all the time, so a hard failure does not sound like
> a bad thing to me either.
Ok, fine with me!
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-06-27 07:48:38 | pgsql: Error message refactoring |
| Previous Message | Michael Paquier | 2021-06-27 01:22:24 | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tsunakawa.takay@fujitsu.com | 2021-06-27 07:41:19 | Farewell greeting |
| Previous Message | Pavel Stehule | 2021-06-27 04:31:34 | Re: Deparsing rewritten query |