| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>, "Jawarilal, Manish" <Manish(dot)Jawarilal(at)dell(dot)com> |
| Subject: | Re: pgbench bug / limitation |
| Date: | 2020-06-06 06:59:57 |
| Message-ID: | alpine.DEB.2.22.394.2006060851480.32228@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hello Tom,
> Agreed. Seems like the best answer is to get in bed with the Windows
> representation of fd_set, since we cannot avoid knowing that it is
> different from other platforms' versions. I suggest that we might as
> well get all the way in and dodge the FD_SETSIZE limitation altogether,
> as per the attached utterly-untested draft patch.
ISTM that the patch your propose, a full reimplementation of the abstract
poll/select fd set interface for windows, is overkill because it adds
about 80 lines of code. ISTM that just redefining some macros is enough to
get the same performance benefit without adding much to the code base, but
maybe I'm missing something. At least, I do not think that getting rid of
the FD_SETSIZE redefinition for windows is worth all that trouble.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyle Kingsbury | 2020-06-06 12:49:56 | Re: Potential G2-item cycles under serializable isolation |
| Previous Message | Peter Geoghegan | 2020-06-05 22:44:51 | Re: Potential G2-item cycles under serializable isolation |