Re: Allow continuations in "pg_hba.conf" files

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow continuations in "pg_hba.conf" files
Date: 2020-03-25 20:45:40
Message-ID: alpine.DEB.2.21.2003252136490.15243@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Justin,

thanks for the feedback.

>> - Records cannot be continued across lines.
>> + Records can be backslash-continued across lines.
>
> Maybe say: "lines ending with a backslash are logically continued on the next
> line", or similar.

I tried to change it along that.

> Since it puts a blank there, it creates a "word" boundary, which I gather
> worked for your use case. But I wonder whether it's needed to add a space (or
> otherwise, document that lines cannot be split beween words?).

Hmmm. Ok, you are right. I hesitated while doing it. I removed the char
instead, so that it does not add a word break.

> Note, that also appears to affect the "username maps" file. So mention
> in that chapter, too.
> https://www.postgresql.org/docs/current/auth-username-maps.html

Indeed, the same tokenizer is used. I updated a sentence to point on
continuations.

--
Fabien.

Attachment Content-Type Size
pg-hba-cont-2.patch text/x-diff 3.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-03-25 20:54:33 Re: backup manifests
Previous Message Tom Lane 2020-03-25 20:42:31 Re: Spurious "apparent wraparound" via SimpleLruTruncate() rounding