Re: Add %x to PROMPT1 and PROMPT2

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add %x to PROMPT1 and PROMPT2
Date: 2020-01-29 07:25:08
Message-ID: alpine.DEB.2.21.2001271250190.24374@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Vik,

>> Isn't there examples in the documentation which use the default prompts?
>>
>> If so, should they be updated accordingly?
>
> Good catch!
> I thought about the documentation but not the examples therein.
>
> Updated patch attached.

Ok.

Only one transaction prompt example in the whole documentation:-(
No tests is troubled by the change:-(
Sigh…

Patch applies and compiles cleanly, global and psql make check ok.

Doc build ok.

Works for me.

I'd be in favor of adding a non trivial session example in psql
documentation at the end of the prompt stuff section, something like:

BEGIN;
CREATE TABLE
Word(data TEXT PRIMARY KEY);
COPY Word(data) FROM STDIN;
hello
\.
SELECT 2+;
ROLLBACK;

but this is not necessary for this patch.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-01-29 07:29:55 Re: adding partitioned tables to publications
Previous Message Michael Paquier 2020-01-29 07:24:11 Re: [PATCH] Windows port, fix some resources leaks