| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - use pg logging capabilities |
| Date: | 2020-01-01 21:55:29 |
| Message-ID: | alpine.DEB.2.21.2001012219590.23377@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Peter,
> The patch seems pretty straightforward, but this
>
> +/*
> + * Convenient shorcuts
> + */
> +#define fatal pg_log_fatal
> +#define error pg_log_error
> +#define warning pg_log_warning
> +#define info pg_log_info
> +#define debug pg_log_debug
>
> seems counterproductive. Let's just use the normal function names.
I'm trying to keep the column width under control, but if you like it
wider, here it is.
Compared to v1 I have also made a few changes to be more consistent when
using fatal/error/info.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-logging-2.patch | text/x-diff | 40.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2020-01-01 23:15:47 | Re: reduce size of fmgr_builtins array |
| Previous Message | Fabien COELHO | 2020-01-01 21:19:52 | Re: pgbench - use pg logging capabilities |