From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: TAP testing for psql's tab completion code |
Date: | 2019-12-30 10:49:28 |
Message-ID: | alpine.DEB.2.21.1912301144560.14206@pseudo |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>> That is what my patch does: it tests prompts, tab completion, help,
>> command options… and I added tests till I covered most psql source.
>
> Well, I think that where possible we ought to test using the existing
> test infrastructure -- help, for example, seems like it could perfectly
> well be tested in src/test/regress/sql/psql.sql, or we could move stuff
> out to a new set of SQL test scripts under src/bin/psql/sql/,
I do not think it is a good idea, because help output is quite large,
there are many of them, and we should certainly not want it stored
repeatedly in output files for diffs. I rather trigger the output and only
check for some related keywords, so that it fits TAP tests reasonably
well.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Vik Fearing | 2019-12-30 10:56:17 | Re: Recognizing superuser in pg_hba.conf |
Previous Message | Amit Kapila | 2019-12-30 10:19:03 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |