Re: TAP testing for psql's tab completion code

Hello Tom,

>> If you have to install IO::Pty anyway, ISTM you can also install Expect.
>
> My point is precisely that buildfarm owners *won't* have to install
> IO::Pty; it comes in a default Perl install almost everywhere.
> I'm afraid that's not true of Expect.

Hmmm. That is a good argument.

> Now in both cases we could avoid raising the bar by allowing the
> script to "skip" if the module isn't there.

Yep.

>> IO::Pty documentation says that it is "mainly used by Expect", which is a
>> clue that IO::Pty is not much better than Expect as a dependency.
>
> You're just guessing, not looking at facts on the ground. [...]

I'm not guessing what the documentation says:-) But for the consequences,
indeed I was guessing.

> Well, actually, it's possible that on some of these boxes it was pulled
> in by the IPC::Run package,

Ah, you are guessing right, IPC::Run requires IO::Pty, so it should be
available everywhere the buildfarm scripts already run. Maybe.

I've looked at your PoC implementation:

I'm not fan of relying on the configure stuff ("with_readline"), in my
Expect version I tested if history capabilities are available from psql
itself.

I did not paid attention not to overwrite the psql history file, though.

For the psql coverage patch, I was more ambitious and needed less
assumption about the configuration, I only forced -X.

--
Fabien.