From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: psql's \watch is broken |
Date: | 2019-12-14 12:49:08 |
Message-ID: | alpine.DEB.2.21.1912141257230.31008@pseudo |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>> I've not dug into code itself, I just bisected it.
>>
>> Thanks for the report. I'll look into it.
>
> Looked at it already.
Ah, the magic of timezones!
> And yes, I can see the difference. This comes from the switch from
> cancel_pressed to CancelRequested in psql, especially PSQLexecWatch() in
> this case. And actually, now that I look at it, I think that we should
> simply get rid of cancel_pressed in psql completely and replace it with
> CancelRequested. This also removes the need of having cancel_pressed
> defined in print.c, which was not really wanted originally. Attached is
> a patch which addresses the issue for me, and cleans up the code while
> on it. Fabien, Jeff, can you confirm please?
Yep. Patch applies cleanly, compiles, works for me as well.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2019-12-14 17:32:25 | Re: Memory-Bounded Hash Aggregation |
Previous Message | Dent John | 2019-12-14 12:09:09 | Re: [WIP] UNNEST(REFCURSOR): allowing SELECT to consume data from a REFCURSOR |