| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench -i progress output on terminal |
| Date: | 2019-11-30 07:27:51 |
| Message-ID: | alpine.DEB.2.21.1911300818580.12334@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Amit,
> I have updated the patch based on these observations. Attached v2.
Patch v2 applies & compiles cleanly, works for me.
I'm not partial to Hungarian notation conventions, which is not widely
used elsewhere in pg. I'd suggest eolchar -> eol or line_end or whatever,
but others may have different opinion. Maybe having a char variable is a
rare enough occurence which warrants advertising it.
Maybe use fputc instead of fprintf in the closing output?
I'm unsure about what happens on MacOS and Windows terminal, but if it
works for other commands progress options, it is probably all right.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Fedorov | 2019-11-30 09:28:18 | Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch |
| Previous Message | Noah Misch | 2019-11-30 06:05:14 | Recovery vs. RelationTruncate(); skipFsync vs. unlogged rels |