Re: fe-utils - share query cancellation code

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: fe-utils - share query cancellation code
Date: 2019-11-06 09:41:39
Message-ID: alpine.DEB.2.21.1911061029540.5547@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> It looks like don't define sigint_interrupt_jmp and
> sigint_interrupt_enabled on Windows, yet they are still declared and
> referenced?

Indeed, I put it on the wrong side of a "#ifndef WIN32".

Basically it is a false constant under WIN32, which it seems does not have
sigint handler, but the code checks whether the non existent handler is
enabled anyway.

Patch v5 attached fixes that, hopefully.

--
Fabien.

Attachment Content-Type Size
fe-cancel-5.patch text/x-diff 22.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2019-11-06 09:41:50 Re: [HACKERS] Block level parallel vacuum
Previous Message Pavel Stehule 2019-11-06 09:40:14 Re: Checking return value of SPI_execute