| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - allow to create partitioned tables |
| Date: | 2019-10-01 06:20:59 |
| Message-ID: | alpine.DEB.2.21.1910010818060.26362@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Amit,
> 1. ran pgindent
> 2. As per Alvaro's suggestions move few function definitions.
> 3. Changed one or two comments and fixed spelling at one place.
Thanks for the improvements.
Not sure why you put "XXX - " in front of "append_fillfactor" comment,
though.
> + fprintf(stderr,
> + "no pgbench_accounts table found in search_path\n"
> + "Perhaps you need to do initialization (\"pgbench -i\") in database
> \"%s\"\n", PQdb(con));
> Can anyone else think of a better error message either in wording or
> style for above case?
No better idea from me. The second part is a duplicate from a earlier
comment, when getting the scale fails.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2019-10-01 06:28:03 | Re: Attempt to consolidate reading of XLOG page |
| Previous Message | Andrey Borodin | 2019-10-01 06:20:39 | Re: Optimize partial TOAST decompression |