From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgbench - allow to create partitioned tables |
Date: | 2019-09-17 18:49:12 |
Message-ID: | alpine.DEB.2.21.1909172021460.9212@lancre |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Attached v9:
- remove the PART_UNKNOWN and use partitions = -1 to tell
that there is an error, and partitions >= 1 to print info
- use search_path to find at most one pgbench_accounts
It still uses left join because I still think that it is appropriate.
I added a lateral to avoid repeating the array_position call
to manage the search_path, and use explicit pg_catalog everywhere.
- let the wrongly repeated test name as is
- somehow use pg_checksums tablespace creation method, however:
- I kept testing that mkdir succeeds
- I kept escaping single quotes, if the path contains a "'"
so the only difference is that on some msys platform it may
avoid some unclear issue.
--
Fabien.
Attachment | Content-Type | Size |
---|---|---|
pgbench-init-partitioned-9.patch | text/x-diff | 12.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bossart, Nathan | 2019-09-17 19:34:45 | Re: ERROR: multixact X from before cutoff Y found to be still running |
Previous Message | Paul Draper | 2019-09-17 18:03:20 | Re: Implementing Incremental View Maintenance |