Re: refactoring - share str2*int64 functions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: refactoring - share str2*int64 functions
Date: 2019-09-16 17:17:27
Message-ID: alpine.DEB.2.21.1909161911270.23349@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Bonjour Michaël,

>> Otherwise, this batch of changes looks ok to me.
>
> Thanks.

About v15: applies cleanly, compiles, "make check" ok.

While re-reading the patch, there are bit of repetitions on pg_strtou?int*
comments. I'm wondering whether it would make sense to write a global
comments before each 3-type series to avoid that.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2019-09-16 17:36:29 Re: Define jsonpath functions as stable
Previous Message Stephen Frost 2019-09-16 17:10:50 Re: block-level incremental backup