Re: [PATCH] Implement uuid_version()

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net>
Subject: Re: [PATCH] Implement uuid_version()
Date: 2019-06-30 13:50:15
Message-ID: alpine.DEB.2.21.1906301546040.23641@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Peter,

>> Yeah, I think implementing a v4 generator in core would be trivial and
>> address almost everyone's requirements.
>
> Here is a proposed patch for this. I did a fair bit of looking around
> in other systems for a naming pattern but didn't find anything
> consistent. So I ended up just taking the function name and code from
> pgcrypto.
>
> As you can see, the code is trivial and has no external dependencies. I
> think this would significantly upgrade the usability of the uuid type.

Patch applies cleanly.

However it does not compile, it fails on: "Duplicate OIDs detected: 3429".

Someone inserted a new entry since it was produced.

I'm wondering whether pg_random_uuid() should be taken out of pgcrypto if
it is available in core?

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-06-30 16:09:18 Re: Where is SSPI auth username determined for TAP tests?
Previous Message Alexander Lakhin 2019-06-30 13:06:47 Fix typos and inconsistencies for HEAD