Re: fix psql \conninfo & \connect when using hostaddr

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: fix psql \conninfo & \connect when using hostaddr
Date: 2019-06-12 08:24:31
Message-ID: alpine.DEB.2.21.1906121021170.13288@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Noah,

>>>> Although I guess it can be avoided by `-reuse-previous=off`, probably it
>>>> makese sense to update the docs.
>>>
>>> Yep, that is one option. The other is to revert or alter the subtle
>>> change, but ISTM that it made sense in some use case, so I wanted some
>>> time to think about it and test.
>>
>> Sure, no one argue that the behaviour should be changed, it's only about the
>> documentation part.
>
> No, I was arguing that a behavior should revert back its v11 behavior:

I got that. I'm working on it, and on the other issues you raised.

The issue I see is what do we want when a name resolves to multiple
addresses. The answer is not fully obvious to me right now. I'll try to
send a patch over the week-end.

> \connect mydb myuser myhost
> -- should resolve "myhost" again, like it did in v11
> \connect
>
> \connect "dbname=mydb host=myhost hostaddr=127.0.0.1"
> -- ok to reuse hostaddr=127.0.0.1; I agree that's a feature
> \connect

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2019-06-12 08:24:46 Re: set parameter for all existing session
Previous Message Michael Paquier 2019-06-12 08:00:55 Re: pg_basebackup failure after setting default_table_access_method option